Can't Use different Server-Icon.png sizes

[KAMKEEL]

When you have a server-icon.png that is of different size from 64 pixels. This occurs. It doesn't seem to happen on KCauldron or UraniumMC

java.lang.IllegalArgumentException: Must be 64 pixels wide
at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[Validate.class:2.6]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadServerIcon0(CraftServer.java:262) ~[CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadServerIcon0(CraftServer.java:256) ~[CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadIcon(CraftServer.java:824) [CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.(CraftServer.java:236) [CraftServer.class:1.7.10-4.1]
at net.minecraft.server.management.ServerConfigurationManager.(ServerConfigurationManager.java:130) [oi.class:?]
at net.minecraft.server.dedicated.DedicatedPlayerList.(SourceFile:14) [ls.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:234) [lt.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:641) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]
[18:55:12 WARN]: Couldn't load server icon
java.lang.IllegalArgumentException: Must be 64 pixels wide
at org.apache.commons.lang.Validate.isTrue(Validate.java:136) ~[Validate.class:2.6]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadServerIcon0(CraftServer.java:262) ~[CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadServerIcon0(CraftServer.java:256) ~[CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadIcon(CraftServer.java:824) [CraftServer.class:1.7.10-4.1]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.(CraftServer.java:240) [CraftServer.class:1.7.10-4.1]
at net.minecraft.server.management.ServerConfigurationManager.(ServerConfigurationManager.java:130) [oi.class:?]
at net.minecraft.server.dedicated.DedicatedPlayerList.(SourceFile:14) [ls.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:234) [lt.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:641) [MinecraftServer.class:?]

[EverNife]

Crucible code:

Crucible/src/main/java/org/bukkit/craftbukkit/CraftServer.java

Lines 259 to 268 in bd5db79

	static CraftIconCache loadServerIcon0(BufferedImage image) throws Exception {
	ByteBuf bytebuf = Unpooled.buffer();
	Validate.isTrue(image.getWidth() == 64, "Must be 64 pixels wide");
	Validate.isTrue(image.getHeight() == 64, "Must be 64 pixels high");
	ImageIO.write(image, "PNG", new ByteBufOutputStream(bytebuf));
	ByteBuf bytebuf1 = Base64.encode(bytebuf);
	return new CraftIconCache("data:image/png;base64," + bytebuf1.toString(Charsets.UTF_8));
	}

Uranium code:
https://github.com/UraniumMC/Uranium/blob/7686a6bd7781d69a17832dc2b0c5dcd0a4c9980a/src/main/java/org/bukkit/craftbukkit/CraftServer.java#L1746-L1755

Codes are the same for both Uranium and Crucible, i will test it soon on other version.

[KAMKEEL]

I know for a fact that server-icons of different sizes for both the Dev and Stable versions of Uranium, so it must be another line somewhere else. The png file I was using was 600x600 pixels if you were wondering.

[EverNife]

Ok, tested it on other platforms. Its not a bug, its an intended behavior.

Not even on 1.12.2 this is allowed (tested on Mohist).

But this is something we may be able to get done.

[juanmuscaria]

You can disable this check by enabling crucible.unsafe