Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHP - Update fastlane version and run on cru shared lanes instead of beta lane #2282

Merged
merged 1 commit into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -268,23 +268,25 @@ jobs:
run: echo -e "machine github.com\n login $CI_USER_TOKEN" >> ~/.netrc
env:
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN}}
- name: Bundle Install
run: bundle install
- name: Import App Store Connect API Key
env:
APP_STORE_CONNECT_API_JSON_PAYLOAD: ${{ secrets.APP_STORE_CONNECT_API_JSON_PAYLOAD }}
run: echo $APP_STORE_CONNECT_API_JSON_PAYLOAD > ios/fastlane/AppleAppStoreApi.json
- name: Increment Xcode Project Build Number
uses: maierj/[email protected]
with:
lane: ios cru_shared_lane_increment_xcode_project_build_number
subdirectory: ios
- name: 🏗️🚀🍏 Build and push to Testflight
uses: maierj/[email protected]
with:
lane: ios beta
lane: ios cru_shared_lane_build_and_deploy_for_testflight_release is_running_in_ci:true
subdirectory: ios
env:
TRAVIS_BRANCH: ${{ github.ref }}
TRAVIS_TAG: ${{ github.ref }}
TRAVIS_COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
TRAVIS_BUILD_NUMBER: ${{ github.run_id }}
MATCH_GIT_BASIC_AUTHORIZATION_PAT: ${{ secrets.MATCH_GIT_BASIC_AUTHORIZATION_PAT }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
FASTLANE_PASSWORD: ${{ secrets.FASTLANE_PASSWORD }}
SLACK_URL: ${{ secrets.SLACK_URL }}

android-deploy:
runs-on: ubuntu-latest
Expand Down
31 changes: 15 additions & 16 deletions ios/.env.default
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@

CRU_API_KEY_PATH = "./fastlane/AppleAppStoreAPI.json"
APP_RELEASE_BUNDLE_IDENTIFIER = "com.missionhub"
APP_STORE_CONNECT_API_KEY_JSON_FILE_PATH = "./fastlane/AppleAppStoreAPI.json"

## Fastlane Build - Project related variables
CRU_FASTLANE_USERNAME="[email protected]"
CRU_APP_IDENTIFIER="com.missionhub"
CRU_TARGET="MissionHub"
CRU_SCHEME="MissionHub"
CRU_XCODEPROJ="MissionHub.xcodeproj"
CRU_DEV_PORTAL_TEAM_ID="DQ48D9BF2V"
## Code Signing
CODE_SIGNING_APP_BUNDLE_IDS = "com.missionhub"
CODE_SIGNING_PROVISIONING_PROFILE_NAMES = "match AppStore com.missionhub"
CODE_SIGNING_TARGETS = "MissionHub"
CODE_SIGNING_TEAM_ID = "DQ48D9BF2V"

CRU_DEFAULT_BRANCH="master"
CRU_SKIP_COCOAPODS="true"
## Match
MATCH_GIT_BRANCH = "master"
MATCH_GIT_URL = "https://github.com/CruGlobal/ios-signing-credentials"
MATCH_KEYCHAIN_NAME = "MissionHub"

## Fastlane Build - Localization related variables
CRU_SKIP_LOCALIZATION_DOWNLOAD="true" # this is handled separately through a yarn script

## Fastlane Build - Code signing related variables
CRU_APPSTORE_PROFILE_NAME="match AppStore com.missionhub"
MATCH_KEYCHAIN_NAME=MissionHub
## Gym
GYM_RELEASE_APP_BUNDLE_IDENTIFIER = "com.missionhub"
GYM_RELEASE_PROVISIONING_PROFILE = "match AppStore com.missionhub"
GYM_RELEASE_SCHEME = "MissionHub"