Remove unused .question-heading-with-hint class

The digitalmarketplace toolkit is no longer using this class, so let's get rid of it.
Crown-Commercial-Service · Feb 24, 2017 · 73b0cc3 · 73b0cc3
1 parent f86b930
commit 73b0cc3
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/app/assets/scss/_supplier-declaration.scss b/app/assets/scss/_supplier-declaration.scss
@@ -2,13 +2,11 @@
 
 .supplier-declaration {
 
-  .question-heading,
-  .question-heading-with-hint {
+  .question-heading {
     font-size: 19px;
     font-weight: normal;
   }
   .question-heading li,
-  .question-heading-with-hint li,
   .hint li {
 
     margin: 10px 0 10px 20px;

diff --git a/app/templates/auth/create_user.html b/app/templates/auth/create_user.html
@@ -24,7 +24,7 @@
                 <div class="validation-wrapper">
                     {% endif %}
                     <div class="question">
-                        {{ form.name.label(class="question-heading-with-hint") }}
+                        {{ form.name.label(class="question-heading") }}
                         <p class="hint">
                             Enter the name to be referred to on the Digital Marketplace
                         </p>
@@ -43,7 +43,7 @@
                 <div class="validation-wrapper">
             {% endif %}
                 <div class="question">
-                    {{ form.password.label(class="question-heading-with-hint") }}
+                    {{ form.password.label(class="question-heading") }}
                     <p class="hint">
                       Must be between 10 and 50 characters
                     </p>

diff --git a/app/templates/macros/toolkit_forms.html b/app/templates/macros/toolkit_forms.html
@@ -222,7 +222,7 @@ <h2>{{ question_content.question }}</h2>
       <span class="visually-hidden">{{ question_content.name }}</span>
     </legend>
 
-    <span class="question-heading{% if question_content.hint %}-with-hint{% endif %}">
+    <span class="question-heading">
       {% if question_number is not none %}
         <span class="question-number">
           {{ question_number }}

diff --git a/app/templates/suppliers/edit_supplier.html b/app/templates/suppliers/edit_supplier.html
@@ -82,7 +82,7 @@ <h3 class="validation-masthead-heading" id="validation-masthead-heading">
       {{ forms.question_input('contact_phoneNumber', 'Phone number', contact_form.phoneNumber.data, errors=contact_form.phoneNumber.errors) }}
 
       <div class="question">
-        <label class="question-heading-with-hint">
+        <label class="question-heading">
           Business address
         </label>
         {{ forms.input('contact_id', contact_form.id.data, type='hidden') }}

diff --git a/tests/app/main/test_briefs.py b/tests/app/main/test_briefs.py
@@ -571,7 +571,7 @@ def test_content_from_manifest_is_shown(self):
 
         doc = html.fromstring(res.get_data(as_text=True))
         assert doc.xpath("//h1/text()")[0].strip() == 'Email address the buyer should use to contact you'
-        assert (doc.xpath("//span[@class=\"question-heading-with-hint\"]/text()")[0].strip() ==
+        assert (doc.xpath("//span[@class=\"question-heading\"]/text()")[0].strip() ==
                 'Email address the buyer should use to contact you')
         assert (doc.xpath("//span[@class=\"question-advice\"]/text()")[0].strip() ==
                 'All communication about your application will be sent to this address.')