[WIP] Bring in new toolkit with new input fields #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in the latest govuk_frontend_toolkit available on NPM, and the latest digitalmarketplace toolkit. Also: - removes external link styles, as these will no longer compile - removes custom focused/selected classes for radios/checks
The govuk_frontend_toolkit stuff uses different javascript formatting than us where they begin their files with semicolons but don't end files with them. Our JS does the opposite, and so concatenating the files results in a compilation bug somewhere in the middle.
The phase banner is now always dark blue, which doesn't work on our homepage. Reversing the colours (white background, blue text) instead.
Javascript will automatically treat links with a `role="button"` and a `.link-button` class as buttons. This is part of the govuk_frontend_toolkit, not the digitalmarketplace one.
The digitalmarketplace toolkit is no longer using this class, so let's get rid of it.
Our secondary action links have a few context dependent styles, so I've added a new one and I've pulled them into their own file. Also removed a duplicated import.
pcraig3
force-pushed
the
pc-try-terrific-new-toolkit
branch
from
a0085ea to
e2213ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't actually be ready to go until the pull request in the frontend toolkit is merged
This pull request
role="button"as buttons (ie, "Apply for this opportunity" link)💥 Boom 💥