Fixed-new-email-api #146
Merged
Fixed-new-email-api #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var messageSettingsVault = JsonConvert.DeserializeObject<MessageSettingsVault>(_secrets.Data["Email"].ToString()); | ||
| Data.Add("Email:ApiKey", messageSettingsVault.ApiKey); | ||
| Data.Add("Email:TemplateId", messageSettingsVault.TemplateId); |
| }, | ||
| "Email": { | ||
| "ApiKey": "", | ||
| "TemplateId": "" |
| @@ -45,5 +47,13 @@ public async Task<bool> Post(MessageRequestModel message) | |||
| { | |||
| return await _messageProviderService.SendMessage(message); | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
add description for this API, take reference of sms API
| public async Task SendEmailAsync(EmailInfo emailInfo) | ||
| { | ||
| var apiKey = _configuration["Email:ApiKey"]; | ||
| var templateId = !string.IsNullOrEmpty(emailInfo.TemplateId) ? emailInfo.TemplateId : _configuration["emailInfo:TemplateId"]; |
There was a problem hiding this comment.
we will not have TemplateId in config..
| _configuration = configuration; | ||
| _httpClientFactory = httpClientFactory; | ||
| } | ||
| public async Task SendEmailAsync(EmailInfo emailInfo) |
There was a problem hiding this comment.
add try catch in this method, refer sms method.
| _configuration = configuration; | ||
| _httpClientFactory = httpClientFactory; | ||
| } | ||
| public async Task SendEmailAsync(EmailInfo emailInfo) |
There was a problem hiding this comment.
add required validation for email fields like To, TemplateId
brijeshpatel-bc
approved these changes
Jun 15, 2023
ponselvamsakthivel-bc
added a commit
to ponselvamsakthivel-bc/ccs-ppg-notification-api
that referenced
this pull request
Jul 5, 2024
…-Service/new-email-api Fixed-new-email-api
ponselvamsakthivel-bc
added a commit
that referenced
this pull request
Aug 8, 2024
Fixed-new-email-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.