Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to associate an image with a reward #170

Merged
merged 2 commits into from
Dec 24, 2013
Merged

Conversation

mattlebel
Copy link
Contributor

Addresses issue #80.

Campaign admins can now add an optional image to each reward they create.

@liuhenry
Copy link
Contributor

+1

mattlebel added a commit that referenced this pull request Dec 24, 2013
Added ability to associate an image with a reward
@mattlebel mattlebel merged commit 6efc704 into master Dec 24, 2013
@mattlebel mattlebel deleted the reward_images branch December 24, 2013 00:40
@liuhenry
Copy link
Contributor

liuhenry commented Jan 6, 2014

Quick update - reward validation needs :allow_blank => true, it's rejecting empty image url rewards


validates :title, :description, :delivery_date, :price, presence: true
validates :image_url, :format => URI::regexp(%w(http https))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:allow_blank => true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants