Some improvements #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galster-dev
requested changes
Jul 13, 2023
| @@ -30,7 +30,7 @@ public static void Postfix(CreateOptionsPicker __instance) | |||
| var playerButton = __instance.MaxPlayerButtons[i]; | |||
|
|
|||
| var tmp = playerButton.GetComponentInChildren<TextMeshPro>(); | |||
| var newValue = Mathf.Max(byte.Parse(tmp.text) - 10, byte.Parse(playerButton.name)); | |||
| var newValue = Mathf.Max(byte.Parse(tmp.text) - 10, byte.Parse(playerButton.name) - 2); | |||
There was a problem hiding this comment.
I'd stick to 4 tbh, but 3 is fine I guess
There was a problem hiding this comment.
honestly i thought of it as funny seeing a 3 player lobby, it's merely a joke-ish change which i'm willing to change to 4 if needed
|
oops accidentally requested review my bad will make those changes |
|
im thinking of moving PageText.text = $"({PageIndex + 1}/{MaxPageIndex + 1})"; into the OnPageChanged() method instead of Update() |
|
worked on it a wee bit more, and went ahead with my earlier idea |
|
so is this pr good enough to be merged? or is there something else that's to be done |
|
@Galster-dev made your requested changes |
Galster-dev
reviewed
Oct 23, 2023
| { | ||
| __instance.CrewArea.SetCrewSize(opts.MaxPlayers, opts.NumImpostors); | ||
| } | ||
| __instance.CrewArea?.SetCrewSize(opts.MaxPlayers, opts.NumImpostors); |
There was a problem hiding this comment.
? operator bypasses Unity lifetime checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains
Haven't been able to test it fully since 15+ player lobbies are rare, but through some solo testing using bots they work for the most part