Update the eslint config and pnpm version in order to fix the build #327
Conversation
|
JackRobards
changed the title
| @@ -9,7 +9,7 @@ | |||
| "masterIssue": true, | |||
| // bump for apps | |||
| // update-lockfile for addons/libraries | |||
| "rangeStrategy": "bump", | |||
| "rangeStrategy": "update-lockfile", | |||
There was a problem hiding this comment.
I was hoping this might help with keeping this more consistent across different open source CrowdStrike repos. Both ember-toucan-styles and ember-toucan-core are using the "update-lockfile" strategy. I'm not too familiar with configuring renovate though, so let me know if this is a bad idea!
Docs:
https://docs.renovatebot.com/configuration-options/#rangestrategy
There was a problem hiding this comment.
Makes sense to me to keep these all consistent 👍
| @@ -81,6 +84,6 @@ | |||
| "packageManager": "[email protected]", | |||
| "volta": { | |||
There was a problem hiding this comment.
For anyone who might be curious how volta respects (or doesn't for now) this packageManager field, I found these issues with some context:
| @@ -9,7 +9,7 @@ | |||
| "masterIssue": true, | |||
| // bump for apps | |||
| // update-lockfile for addons/libraries | |||
| "rangeStrategy": "bump", | |||
| "rangeStrategy": "update-lockfile", | |||
There was a problem hiding this comment.
Makes sense to me to keep these all consistent 👍
- The CI pnpm version was out of sync with the package.json version. - The tests app was using older versions of typescript and vitest - The .eslintignore was missing a build directories, resulting in slow linting times
…e build - Bump TypeScript version, since CI wasn't using a frozen lockfile for TypeScript version. - Add "rangeStrategy": "update-lockfile", for renovate settings - Various small fixes to adjust to new eslint settings
To fix an error in conflicting versions of @types/node
JackRobards
force-pushed
the
jrobards/bump-pnpm-version
branch
from
3685d28 to
c074097
Compare
The build is failing across all of the PRs on this repo, preventing any new changes from being merged. e.g. https://github.com/CrowdStrike/tailwind-toucan-base/actions/runs/6162755087/job/16726205458?pr=326
I believe this error ultimately has to do with the CI installing TypeScripting 5.2, which is incompatible with the older eslint setup in this repo. See: typescript-eslint/typescript-eslint#7155 (you can see the same error message in a comment on that thread). The property this error refers to was deprecated in 5.0, and is no longer usable in 5.2: https://github.com/microsoft/TypeScript/blob/main/src/deprecatedCompat/5.0/identifierProperties.ts#L28
The main goal here was to get the build working by updating the versions, since it seems like it's been awhile since the build config for this repo was updated. I think we could also lock the typescript version to
"typescript": "5.1.6",explicitly to fix the build, but the eslint changes would need to be made in the future anyway once we want to update TypeScript.Notable changes include:
testsdirectory (it still listed 4.7, and did not get updated by renovate).packageManager. Renovate only updated thepnpmdependency, and not these other versions so things were a bit out of sync and confusing.Let me know what you think!