Fix rollup failing w/ floating deps in CI

[simonihmig]

Out of nowhere, CI runs for the floating dependencies scenario started to fail, for all PRs, even when re-running an older previously green run.

Somehow I couldn't reproduce locally (pinning to same node version, and pnpm i --no-lockfile). But I was able to guess the culprit was rollup-plugin-ts, as the only rollup related update of dependencies was the fresh new release of 3.2.0.

And indeed...

• switching to node 18 in CI fixes the issue
• they seem to have realised that their version was not working with node 14 anymore (see wessberg/rollup-plugin-ts@v3.2.0...master), which should then have been a breaking change... 🙄

The switch to a newer node version should be unproblematic here, as

• unlike v1 addons we don't really have a dependency on node for v2 addons, it only plays a role in our own prepublish build step, but not for consumers
• we haven't released this anyway 😅

[simonihmig]

FWIW, this will nevertheless cause a bit of churn in the v2 addon space using this plugin. See e.g. simonihmig/ember-stargate#614

[simonihmig]

@ynotdraw this might also affect your work maybe?

[NullVoxPopuli]

All my repos use this, which supports volta, so I think as long as v2 addons are using volta, they should be safe from the rollup-plugin-ts changes.

It's too bad we can't assume folks have volta installed on their machines for the blueprint, though

[ynotdraw]

@ynotdraw this might also affect your work maybe?

Thank you! 🙇