Fix autocomplete sorting

[gaspergrom]

Changes proposed ✍️

What

copilot:summary
​
copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

• Label appropriately with Feature, Improvement, or Bug.
• Add screenshots to the PR description for relevant FE changes
• New backend functionality has been unit-tested.
• API documentation has been updated (if necessary) (see docs on API documentation).
• Quality standards are met.

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced organization fetching logic to filter results based on the selected project group.
  • Updated autocomplete member and organization listings to prioritize sorting by activity count.

• Bug Fixes

  • Improved parameter handling in autocomplete methods for organizations and members.

• Documentation

  • Updated method signatures to reflect changes in parameter handling and sorting criteria.

These updates enhance the user experience by providing more relevant and organized results in the autocomplete features.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several modifications across different service files related to organization and member management. Key changes include refactoring methods in the OrganizationService class to simplify parameter handling and improve readability. The listMembersAutocomplete and listOrganizationsAutocomplete methods have updated sorting criteria, changing the default order from displayName_ASC to activityCount_DESC. Additionally, the fetchOrganizations function in the organization-select.vue component has been enhanced to filter organizations based on a new segments parameter, integrating state management with Pinia.

Changes

File Path	Change Summary
backend/src/services/organizationService.ts	Refactored findAllAutocomplete and query methods to destructure data parameter, simplifying implementation.
frontend/src/modules/member/member-service.js	Updated listMembersAutocomplete method to change default orderBy from 'displayName_ASC' to 'activityCount_DESC'.
frontend/src/modules/organization/components/shared/organization-select.vue	Modified fetchOrganizations to include segments parameter, integrating with useLfSegmentsStore for filtering.
frontend/src/modules/organization/organization-service.js	Updated listOrganizationsAutocomplete to change default orderBy to 'activityCount_DESC' and refined fetchMergeSuggestions with a comprehensive segments array.

Possibly related PRs

• Org and member view updates (LFX-1664) #2660: The changes in this PR involve modifications to the OrganizationService class, specifically in methods that interact with organization data, which aligns with the refactoring of the findAllAutocomplete and query methods in the main PR. Both PRs focus on enhancing the handling of parameters and improving the efficiency of data retrieval related to organizations.

Suggested reviewers

• epipav

Poem

In the burrows deep, where the code does creep,
A refactor's dance, oh what a leap!
With segments and sorting, we hop and we play,
Making data fetching smoother each day.
From display names to counts, we now prioritize,
In the world of code, we’re clever and wise! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.