Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFX-1481] Fix display of joined date in member merge dialog for unknown date #2648

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

use-tusk[bot]
Copy link

@use-tusk use-tusk bot commented Oct 9, 2024

This PR addresses the issue where the joined date in the member merge dialog shows the fallback date '1970-01-01' when the joined date is unknown. The frontend code has been modified to display '-' instead of the fallback date.

The changes were made in the member-merge-suggestions-details.vue, member-model.js, and date-time-field.js files to ensure that the display is corrected throughout the relevant components.


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review to address nits. If major changes are needed, retry the issue from the Tusk app with additional context.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs or issue to see more details.

Copy link
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is failing

Copy link
Author

use-tusk bot commented Oct 9, 2024

Addressing your review. View activity logs for details.

Copy link
Author

use-tusk bot commented Oct 9, 2024

@joanreyero I've addressed your review. Add another review if minor changes are needed. If major changes are needed, retry the issue from the Tusk app with additional context.

@use-tusk use-tusk bot requested a review from joanreyero October 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant