-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake install rules #80
Conversation
This is what i understand after reading discussion on #68. Let me know if i am missing something or if this is fine i will add this in documentation too. |
If you want to link an issue in such a way that this PR closes it, you should look at https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
yes i know this already, The reason i type it there is because i cannot link issue from the right cloumn of the web page. i don't know there may be some access rights issue which is not allowing me to link issue from there. Linked Issue option is disabled for me |
Yes, you can link in issue by typing |
Thanks! got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems to work fine.
You can add the documentation if you want or leave it to me.
If you choose to do it, you should explain the make install
command as an alternative to make
in line 97 of docs/getting_started/setup.md
and explain what it does.
okay, will do that soon, once i do that you can thereafter give suggestions to improve upon that. |
closes #68
To install crow globally, one should run
make install
instead ofmake
aftercmake ..
this will automatically copycrow_all.h
to/usr/local/include
. Thus making it available gloablly