Allow multiple executions of validate() (#672)
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanoPetrilli
force-pushed
the
allow_multiple_executions_of_validate
branch
2 times, most recently
from
1c93a4a
to
5ab72ed
Compare
cschreib
reviewed
Jul 8, 2023
cschreib
reviewed
Jul 8, 2023
|
Looks good to me. NB, I'm not a maintainer so I can't actually approve the PR for merging. But from my point of view, this would indeed fix #672. |
|
it seems a rebase onto master is needed. |
StefanoPetrilli
force-pushed
the
allow_multiple_executions_of_validate
branch
from
2f7e943
to
46ab30d
Compare
|
@gittiver I rebased this on master 👍 |
gittiver
requested review from
mrozigor,
dranikpg,
The-EDev and
luca-schlecker
and removed request for
cschreib
|
thx, all checks passing, requested review by other team members. |
gittiver
added
feature
mrozigor
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#672
I separated the different
validate()responsibilities into other functions. It's now possible to executevalidate()multiple times as it only performs validation.Is this proposed solution all right? If so I will proceed with writing the tests.