Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework the way asio is handled as a dependency. #482

Merged
merged 1 commit into from
Jun 22, 2022
Merged

rework the way asio is handled as a dependency. #482

merged 1 commit into from
Jun 22, 2022

Conversation

luca-schlecker
Copy link
Collaborator

@luca-schlecker luca-schlecker commented Jun 22, 2022 •
edited
Loading

Introduces a Findasio.cmake module helping with adding asio as a dependency.
The module looks for the asio.hpp file and creates a CMake interface target for it and automatically links against Threads which asio relies on.

This has the advantage of improving find_package support and it fixes #477.

The-EDev
The-EDev approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@The-EDev The-EDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be alright

@luca-schlecker luca-schlecker merged commit c56f101 into master Jun 22, 2022
@luca-schlecker luca-schlecker deleted the asio_fix branch June 22, 2022 16:38
@The-EDev The-EDev mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EDev The-EDev The-EDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling on Visual Studio 2022 (with vcpkg) Windows 10
2 participants
@luca-schlecker @The-EDev