Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: don't append std::endl to the message. #290

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

luca-schlecker
Copy link
Collaborator

ILogHandler instances should take care of that:

class CustomLogger : public crow::ILogHandler {
 public:
  CustomLogger() {}
  void log(std::string message, crow::LogLevel /*level*/) {
    // "message" doesn't contain the timestamp and loglevel
    // prefix the default logger does and it doesn't end
    // in a newline.
    std::cerr << message << std::endl;
  }
};

Signed-off-by: Luca Schlecker [email protected]

ILogHandler instances should take care of that.

Signed-off-by: Luca Schlecker <[email protected]>
@The-EDev
Copy link
Member

Will merge once tests are done

@The-EDev The-EDev merged commit d5822ba into master Nov 29, 2021
@The-EDev
Copy link
Member

The-EDev commented Nov 30, 2021

I completely forgot about the newline at the start.. checking everything it seems to be a non issue, my bad.

@The-EDev The-EDev deleted the wip-luca-schlecker branch April 5, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants