Add unit test for server timeout.

[luca-schlecker]

Signed-off-by: Luca Schlecker [email protected]

This is a preparation for my work on dumb_timer_queue (#264 and thus #273).
It tries to test the timeout value by checking if the tcp socket reaches eof in the specified amount of time indicating that the server closed the connection.

[The-EDev]

I made a mental note a couple days ago about the fact that timeout isn't being tested, but you beat me to it 😂

[luca-schlecker]

Any ideas why it's not working? I suspect the problem in these lines:

status = receive_future.wait_for(chrono::seconds(2));
CHECK(status == future_status::ready);

Could it be that the CI takes longer than 2 seconds to transfer the message and thus the receive call didn't yet return?

[The-EDev]

I'm looking into it now

[The-EDev]

welp :|

[luca-schlecker]

That's what I've thought too... Works on my machine locally.

[luca-schlecker]

Interesting, I've made the timings looser and now the test passes...

[The-EDev]

Well, tests are working, only part of timer not being tested is a case where io_service doesn't exist. The only thing I have to complain about is styling, but that should be fixed soon with clang-format. Great work!

[luca-schlecker]

Sorry about the style, Crow's written in a different style to mine (which is based on Google's style), and thus autoformat can't really help me. Yes, should be fixed with clang-format.

[luca-schlecker]

And I honestly still can't figure out what that io_service object is doing there. It just fails when it's not there, but it's not being used...

I am tempted to just leave it out in my small rework of the dumb_timer_queue.

[The-EDev]

I'm guessing it's for redundancy, so that the timer doesn't execute any timeout callbacks if there is no io_service (since they'll probably always depend on it)

[The-EDev]

Sorry about the style, Crow's written in a different style to mine (which is based on Google's style), and thus autoformat can't really help me. Yes, should be fixed with clang-format.

No worries, I've already written a new clang-format file, I'm just struggling with automated messages showing formatting errors when running CI.

[luca-schlecker]

Well, functions get executed by asking a dumb_timer_queue to do its work over and over again. But I guess that's a discussion for my upcoming PR.