Eliminate extern-initializer warning #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including
crow.h
(or, rather,routing.h
) withoutCROW_MAIN
, theINVALID_BP_ID
variable is declared as extern, which is triggers the-Wextern-initializer
warning (at least with clang):Since Crow is header-only, this means that any sources using Crow cannot be compiled with
-Werror
or similar. This PR simply removes the initialzer when declaring as extern.