Improve usability of CLI processor #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses CriticMarkup#33 Just using `open` tends to expect ASCII encoding. UTF-8 seems to be a more sensible default. Maybe in the long run, an encoding parameter makes sense?
The previous version failed with input file names that contained no
path component (i.e. were absolutely relative to the current
directory). In this case, "" was joined with "/<input file base
name>.html", which gave a file in the root directory ("/"), which is
both wrong and potentially dangerous (moreover, "/" is normally not
writeable for normal users). Using the absolute path of the input file
avoids this.
|
.. that sounds quite reasonable... any reason this is not merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(-e|--encoding)argument to CLI processor, which should fix Doesn't work with cyrillic texts #33