Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Details Tooltip Styling #1159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Chat: Details Tooltip Styling #1159

wants to merge 4 commits into from

Conversation

pablo014
Copy link
Contributor

@pablo014 pablo014 commented Oct 1, 2024

Add Avatar Image to the tooltip

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.87%. Comparing base (f9ee960) to head (c2fbaf7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   17.84%   17.87%   +0.02%     
==========================================
  Files         413      413              
  Lines       65374    65393      +19     
  Branches     1346     1351       +5     
==========================================
+ Hits        11667    11687      +20     
+ Misses      53707    53706       -1     
Flag Coverage Δ
unitTests 17.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

Playwright test results

failed  6 failed
passed  38 passed
flaky  6 flaky

Details

stats  50 tests across 11 suites
duration  11 minutes, 25 seconds
commit  c2fbaf7

Failed tests

firefox › authentication.test.ts › Authentication › should load unauthorized routes as expected with and without authentication - ( @slow @primary @development @staging @production )
firefox › basic.test.ts › should have valid title & url - ( @fast @primary @read @development @staging @production )
chromium › pages/phone.test.ts › PhonePage › should have visible data-testids - ( @primary @slow @read @development @staging @production )
firefox › pages/phone.test.ts › PhonePage › should have visible data-testids - ( @primary @slow @read @development @staging @production )
chromium › pages/work.test.ts › WorkPage › should have visible data-testids - ( @primary @slow @read @development @staging @production )
firefox › pages/work.test.ts › WorkPage › should have visible data-testids - ( @primary @slow @read @development @staging @production )

Flaky tests

firefox-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
firefox-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
firefox-setup › auth.setup.ts › authenticate as admin - ( @primary @slow @read @development @staging @production )
chromium › authentication.test.ts › Authentication › should redirect from login related unauthorized pages with existing session - ( @slow @primary @development @staging @production )
chromium › pages/login.test.ts › LoginPage › should login - ( @fast @primary @development @staging @production )
chromium › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

@deepanchal
Copy link
Contributor

Can you please rebase and fix merge conflicts?

Comment on lines 65 to 70
<<<<<<< HEAD
import { DbService, USER_DATABASE } from '@/services/db.service';
=======
import { getUserAvatarLink } from '../../utils/urls';
import Avatar from '@/components/Avatar.vue';
>>>>>>> feat(detailsTooltip): add image to the side
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this got messed up during merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants