Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulma v1 compatibility #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

deather
Copy link

@deather deather commented Jul 2, 2024

Hello,

This pull request contains the migration to Bulma v1 that was reported on the issue #32 . Here's an exhaustive list of the various changes I've made:

  • Updating the entire sass to css compilation chain;
  • @import replaced by @use and @forward;
  • Conversion of sass files to scss (this is mainly for practicality and consistency with Bulma);
  • Consolidation of all mixins in a single directory, due to the new version of sass, which requires @use;
  • Tooltip component rewritten to match Bulma's css class system level;
  • Documentation update.
  • Adjusting some default color (grey-darker replace by text and grey-lighter replace by border-color)

I've made a minor change to the documentation, as the has-tooltip-multline css class had a typo.
I hope this work will be satisfactory and that it will facilitate the upgrade to the new Bulma API.

Thanks for reading

Charles Jourdan added 3 commits July 2, 2024 18:10
Upgrade sass version (gulp-sass + gulp-clean-css[replacement] + cssnano[replacement])
Convert sass file into scss file using AI
Rpelace @import by @forward or @use
Extract mixin was in src/sass/index to move it in mixins due to the usage of @use
Rewrite the component to use the new cssvar system of bulma
Fix doc get-started with a mistake on tooltip-multiline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant