Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update dependencies #13

wants to merge 4 commits into from

Conversation

Sgiath
Copy link

@Sgiath Sgiath commented Jul 30, 2024

  • added flake.nix for dependency install
  • updated dependencies to their latest versions, except:
    • phantom-js as a whole project is deprecated, and so are the run-browser and zuul packages that are using it (I could not even install it with the latest Node). I was not sure what to replace it with and since it was used only for tests I removed it completely (since we are not even running the tests in CI).
  • one test was failing on .item() not being present on the object so I changed it to [] which should be equivalent according to MDN
  • then one test failed on assertion. After inspecting the test I concluded that it was a bad test so I fixed the code for the test and now it is passing

I am not JS dev though I don't know what this library does so someone should check it before merging!

https://app.shortcut.com/crazyegg/story/48069/review-categorize-and-update-repos

@Sgiath Sgiath requested a review from shravanjoopally July 30, 2024 08:23
@Sgiath Sgiath self-assigned this Jul 30, 2024
Signed-off-by: sgiath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant