CRAYSAT-1912: Get K8s version from node-images #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the cray-sat image build process to get the Kubernetes version from its new location in the node-images repository instead of the old version in the deprecated metal-provision repository. This is more involved than just changing the repository URL and path in the `docker_scripts/config-docker-sat.sh` script because the node-images repository is private in GitHub, but metal-provision was public. Thus we need to authenticate to GitHub when cloning this repository. This is best achieved through a `git` command in the Jenkinsfile. In order to continue supporting local builds, add a target to the `Makefile` that clones the node-images repository if it does not already exist. Use the `git` protocol instead of `https` to allow it to use the user's configured SSH keypair to authenticate when cloning the repo. In either case, the node-images repository gets bind-mounted during the `RUN` command, so that it can be accessed by the `config-docker-sat.sh` script. Test Description: Built the image locally using `make image`. Then ran the container and executed `kubectl version` to verify the version of the `kubectl` client that was installed. Pushed to Jenkins and verified that the Jenkins pipeline worked.
haasken-hpe
requested review from
mtupitsyn,
rustydb,
shivaprasad-metimath and
annapoorna-s-alt
rustydb
approved these changes
Oct 8, 2024
annapoorna-s-alt
approved these changes
Oct 9, 2024
|
Before merge, we should test the few important places where we use kubectl. In order of importance:
|
|
@annapoorna-s-alt testing results: The testing looks good, hence proceeding with merging the PR |
6 tasks
shivaprasad-metimath
pushed a commit
that referenced
this pull request
Oct 10, 2024
Update the cray-sat image build process to get the Kubernetes version from its new location in the node-images repository instead of the old version in the deprecated metal-provision repository. This is more involved than just changing the repository URL and path in the `docker_scripts/config-docker-sat.sh` script because the node-images repository is private in GitHub, but metal-provision was public. Thus we need to authenticate to GitHub when cloning this repository. This is best achieved through a `git` command in the Jenkinsfile. In order to continue supporting local builds, add a target to the `Makefile` that clones the node-images repository if it does not already exist. Use the `git` protocol instead of `https` to allow it to use the user's configured SSH keypair to authenticate when cloning the repo. In either case, the node-images repository gets bind-mounted during the `RUN` command, so that it can be accessed by the `config-docker-sat.sh` script. Test Description: Built the image locally using `make image`. Then ran the container and executed `kubectl version` to verify the version of the `kubectl` client that was installed. Pushed to Jenkins and verified that the Jenkins pipeline worked. (cherry picked from commit 040f41c)
shivaprasad-metimath
added a commit
that referenced
this pull request
Oct 10, 2024
Update the cray-sat image build process to get the Kubernetes version from its new location in the node-images repository instead of the old version in the deprecated metal-provision repository. This is more involved than just changing the repository URL and path in the `docker_scripts/config-docker-sat.sh` script because the node-images repository is private in GitHub, but metal-provision was public. Thus we need to authenticate to GitHub when cloning this repository. This is best achieved through a `git` command in the Jenkinsfile. In order to continue supporting local builds, add a target to the `Makefile` that clones the node-images repository if it does not already exist. Use the `git` protocol instead of `https` to allow it to use the user's configured SSH keypair to authenticate when cloning the repo. In either case, the node-images repository gets bind-mounted during the `RUN` command, so that it can be accessed by the `config-docker-sat.sh` script. Test Description: Built the image locally using `make image`. Then ran the container and executed `kubectl version` to verify the version of the `kubectl` client that was installed. Pushed to Jenkins and verified that the Jenkins pipeline worked. (cherry picked from commit 040f41c) Co-authored-by: Ryan Haasken <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Update the cray-sat image build process to get the Kubernetes version from its new location in the node-images repository instead of the old version in the deprecated metal-provision repository.
This is more involved than just changing the repository URL and path in the
docker_scripts/config-docker-sat.shscript because the node-images repository is private in GitHub, but metal-provision was public. Thus we need to authenticate to GitHub when cloning this repository. This is best achieved through agitcommand in the Jenkinsfile.In order to continue supporting local builds, add a target to the
Makefilethat clones the node-images repository if it does not already exist. Use thegitprotocol instead ofhttpsto allow it to use the user's configured SSH keypair to authenticate when cloning the repo.In either case, the node-images repository gets bind-mounted during the
RUNcommand, so that it can be accessed by theconfig-docker-sat.shscript.Issues and Related PRs
Testing
Tested on:
Test description:
Built the image locally using
make image. Then ran the container and executedkubectl versionto verify the version of thekubectlclient that was installed.Pushed to Jenkins and verified that the Jenkins pipeline worked.
Risks and Mitigations
Pull Request Checklist