CRAYSAT-1896: Add CFSClient methods to get configurations, sessions
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
force-pushed
the
CRAYSAT-1896-cfs-v3-paging-fix
branch
2 times, most recently
from
e798973
to
3996ca0
Compare
Add methods to the `CFSV2Client` and `CFSV3Client` classes to get a list of all the CFS configurations and sessions. The CFS V3 version handles paging in the same way paging is handled for the `components` resource. This change is needed for the `sat bootprep` command to be updated to support CFS v2 and v3 because it looks through all the existing CFS configurations to determine if there are any existing CFS configurations of the same name. Test Description: Unit tests only so far. This will be tested by pulling it into the corresponding branch in the sat repository that adds CFS v2/v3 support to `sat bootprep`.
haasken-hpe
force-pushed
the
CRAYSAT-1896-cfs-v3-paging-fix
branch
from
3996ca0
to
1e20111
Compare
ethanholen-hpe
approved these changes
Nov 25, 2024
annapoorna-s-alt
approved these changes
Nov 26, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Add methods to the
CFSV2ClientandCFSV3Clientclasses to get a list of all the CFS configurations and sessions. The CFS V3 version handles paging in the same way paging is handled for thecomponentsresource.This change is needed for the
sat bootprepcommand to be updated to support CFS v2 and v3 because it looks through all the existing CFS configurations to determine if there are any existing CFS configurations of the same name.Issues and Related PRs
sat bootprepsat#288Testing
Tested on:
Test description:
Unit tests only so far. This will be tested by pulling it into the
corresponding branch in the sat repository that adds CFS v2/v3 support
to
sat bootprep.Risks and Mitigations
Pretty low risk as it's just adding a couple methods on the CFS client classes.
Pull Request Checklist