Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL-2437 - Bump CSI version to enable VLAN checking #3715

Open
wants to merge 1 commit into
base: release/1.6
Choose a base branch
from

Conversation

trad511
Copy link
Contributor

@trad511 trad511 commented Oct 16, 2024

Summary and Scope

CSI previously allowed overlaps and re-use of VLANs in csi config init which lead to unusable switch configurations. This change alerts CSI users to duplicate and overlapping VLANs in system creational data from system_config.yaml or the CLI. This is for initial system install. This part of CSI is not used for system upgrades.

This change is not backported to previous releases.

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

This was tested on CSI data for all internal systems as well as a couple customer systems. Unit tests were also added to CSI.

Tested on:

  • Odin, Surtur and eight other test/dev systems.

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N/A
  • Was upgrade tested? - No, this is a system install only change.
  • Was downgrade tested? - No, this is a system install only change
  • Were new tests (or test issues/Jiras) created for this change? - No Goss tests were created, CSI unit tests were created.

Risks and Mitigations

No known risks.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@trad511 trad511 requested a review from a team as a code owner October 16, 2024 13:53
@trad511 trad511 changed the title Bump CSI version to enable VLAN checking MTL-2437 - Bump CSI version to enable VLAN checking Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants