CASMCMS-9225: Added paging for component listing; add context managers around requests #408
+611
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents (#396) * CASMCMS-9225: Added basic paging ability for GET requests to list components * Apply suggestions from code review * Update src/bos/server/redis_db_utils.py * Combine id_list and tenant_components in filter function; Immediately return empty list if id_list&tenant_components is empty * Fix mistake in code review update * Fix bug in new components logic * Apply suggestions from code review Co-authored-by: Jason Sollom <[email protected]> --------- Co-authored-by: Jason Sollom <[email protected]>
This was referenced Dec 18, 2024
Open
mharding-hpe
commented
Dec 18, 2024
Fix indentation
CASMCMS-9225: Create generic endpoint classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR for CASMCMS-9225. The summary of the whole shebang is:
My plan is to target this for CSM 1.7. A limited backport will go into previous CSM branches, but nothing this extensive, just out of caution.
I split this PR up into a number of sub-PRs, to make the review easier This PR will not be ready to merge until all of its sub-PRs have merged.
Merged:
Unmerged:
3. Create generic API client class
4. Create ApiClients class and provide it to BOS operators inside a context manager
5. Move PCS client to new paradigm
6. Move BSS client to new paradigm
7. Move CFS client to new paradigm
8. Move BOS client to new paradigm
9. Move IMS client to new paradigm
10. Move HSM client to new paradigm
11. CHANGELOG update, linting, update utils