Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor testcafe e2e tests, make some more code reusable #349

Merged

Conversation

ChristophWersal
Copy link
Collaborator

No description provided.

@ChristophWersal
Copy link
Collaborator Author

@cnrun Here are some suggestions to your PR: Please feel free to merge this into your branch, if you like the changes or just adapt your branch to include some of them.

I personally would also get rid of all comments and all screenshots - unless one can see them in browserstack for different browsers.

@ChristophWersal ChristophWersal merged commit 3aa7eb8 into tests/enhance-e2e-test-coverage Nov 3, 2020
@ChristophWersal ChristophWersal deleted the fix/refactor-e2e-tests branch November 3, 2020 19:24
ChristophWersal added a commit that referenced this pull request Nov 3, 2020
* locate search field

* use search field

* open and close panel for risk description

* add test for "hamburger menu"

* run testcafe file with tests.ts extention.

* Test should test local server.

* add screenshots

* rename .test.ts to spec.ts

* format code

* format code

* take some screenshots

* add some screenshots

* fix typo

* screenshots in ignore list

* remove existence and visibility tests because of redundancy

* tests should run localy

* remove unused configuration entry

* chore: refactor testcafe e2e tests, make some more code reusable (#349)

Co-authored-by: ChristophWersal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant