fix: Persist post code when opening privacy information #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle difference
|
ChristophWersal
approved these changes
Nov 2, 2020
Bundle difference
|
jnnwnk
commented
Nov 3, 2020
| @@ -122,6 +128,10 @@ export const defaultAppState: AppState = { | |||
| currentLayerGroup: defaultLayerGroup, | |||
| infoDialogs: {}, | |||
| userPostalCode: null, | |||
| intro: { | |||
There was a problem hiding this comment.
What about the discussion in Slack? Should we add intro to blacklist or not?
Otherwise we could probably merge this one?
@DanielHabenicht @ChristophWersal @kommander
There was a problem hiding this comment.
My 2 cents: it does not hurt to persist it in the local storage and we might need it later => I would merge it as it is.
kommander
approved these changes
Nov 3, 2020
|
E2E tests are not up-to-date, would merge anyway... |
Bundle difference
|
DanielHabenicht
approved these changes
Nov 3, 2020
ChristophWersal
deleted the
fix/persist-post-code-when-opening-privacy-information
branch
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.