Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid fetching data/geojson multiple times #310

Merged
merged 5 commits into from
Oct 31, 2020
Merged

fix: avoid fetching data/geojson multiple times #310

merged 5 commits into from
Oct 31, 2020

Conversation

kommander
Copy link
Collaborator

Fixes #305

@kommander kommander added the bug Something isn't working label Oct 31, 2020
@restyled-io restyled-io bot mentioned this pull request Oct 31, 2020
Merged
@restyled-io @restyled-commits
Restyled by prettier (#311)
b2d2d31 
Co-authored-by: Restyled.io <[email protected]>
@github-actions
Copy link

Bundle difference

Asset group Old size New size Diff
all 12.14 MB 12.15 MB 2.6 KB (0.02%)
documents 7.15 KB 7.15 KB 0 B (0.00%)
scripts 2.41 MB 2.41 MB 1 KB (0.04%)
stylesheets 181.71 KB 181.71 KB 0 B (0.00%)
images 795.6 KB 795.6 KB 0 B (0.00%)
misc 1016.3 KB 1016.3 KB 0 B (0.00%)

@github-actions
Copy link

Bundle difference

Asset group Old size New size Diff
all 12.14 MB 12.15 MB 2.58 KB (0.02%)
documents 7.15 KB 7.15 KB 0 B (0.00%)
scripts 2.41 MB 2.41 MB 1 KB (0.04%)
stylesheets 181.71 KB 181.71 KB 0 B (0.00%)
images 795.6 KB 795.6 KB 0 B (0.00%)
misc 1016.3 KB 1016.3 KB 0 B (0.00%)

1 similar comment
@github-actions
Copy link

Bundle difference

Asset group Old size New size Diff
all 12.14 MB 12.15 MB 2.58 KB (0.02%)
documents 7.15 KB 7.15 KB 0 B (0.00%)
scripts 2.41 MB 2.41 MB 1 KB (0.04%)
stylesheets 181.71 KB 181.71 KB 0 B (0.00%)
images 795.6 KB 795.6 KB 0 B (0.00%)
misc 1016.3 KB 1016.3 KB 0 B (0.00%)

@github-actions
Copy link

Bundle difference

Asset group Old size New size Diff
all 12.14 MB 12.15 MB 2.25 KB (0.02%)
documents 7.15 KB 7.15 KB 0 B (0.00%)
scripts 2.41 MB 2.41 MB 1.02 KB (0.04%)
stylesheets 181.71 KB 181.71 KB 0 B (0.00%)
images 795.6 KB 795.6 KB 0 B (0.00%)
misc 1016.32 KB 1016.3 KB -13 B (-0.00%)

@kommander kommander merged commit 111c51b into master Oct 31, 2020
@kommander kommander deleted the fix/dataset-multiload branch October 31, 2020 16:05
@github-actions
Copy link

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

onouv pushed a commit that referenced this pull request Nov 3, 2020
@kommander @restyled-io
@restyled-commits @onouv
fix: avoid fetching data/geojson multiple times (#310)
320523f 
* fetch data and geojson only once when re-used

* avoid fetching the same mapping at the same time

* use dataset key with timekey

* Restyled by prettier (#311)

Co-authored-by: Restyled.io <[email protected]>

* refactor: extract data/geo fetching methods

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWersal ChristophWersal ChristophWersal approved these changes

@DanielHabenicht DanielHabenicht Awaiting requested review from DanielHabenicht

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasets and GeoJSONs are loaded multiple times
2 participants
@kommander @ChristophWersal