fix: set error dialog to map component #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DanielHabenicht
commented
Oct 31, 2020
•
DanielHabenicht
commented
- sets the error dialog to the map component so the navigation is still functional
- removes the search if there is no data in order to not run into an error in the search (or confuse the user)
Bundle difference
|
1 similar comment
Bundle difference
|
Bundle difference
|
kommander
approved these changes
Oct 31, 2020
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
onouv
pushed a commit
that referenced
this pull request
Nov 3, 2020
* fix error dialog to map view * remove search if no data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.