feat: provide embed build #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle difference
|
…ssues, multi entry point output not working correctly without html plugin update, which breaks pwa plugin
kommander
force-pushed
the
feature/provide-embed-build
branch
from
f713cf1 to
b4203ae
Compare
Bundle difference
|
…arrow to be next to title
Co-authored-by: Restyled.io <[email protected]>
Bundle difference
|
Bundle difference
|
Bundle difference
|
Wenn dieser PR aber nur den technischen Grundstein legen soll ohne es direkt einsetzbar zu machen, habe ich keine anderen funktionalen Kommentare.
|
| paddingTop: "64px", | ||
| [theme.breakpoints.down("xs")]: { | ||
| // on mobile devices | ||
| paddingTop: "0 !important", |
There was a problem hiding this comment.
!important can be removed. I added it for testing, but it also works without.
There was a problem hiding this comment.
Ok, mach ich nachher noch.
Es soll nur der technische Grundstein sein. Das sind gute Kommentare, so aehnlich hab ich mir das auch vorgestellt. Wuerde diese Issues dann einzeln in weiteren PRs abarbeiten. |
ChristophWersal
approved these changes
Oct 30, 2020
Closed
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@kommander waren es viele Änderungen die du in den embed Dateien vorgenommen hast? Ich würde aufgrund der Übersichtlichtkeit fast sagen das wir es in die ganz normale App mit einbauen (und über build variablen steuern), da ich gerade bei den Error Handler merke das ich alles zweimal machen muss (und es wird in Zukunft sicherlich noch andere Dinge geben) |
onouv
pushed a commit
that referenced
this pull request
Nov 3, 2020
* stash embed setup - broken because of webpack & html-plugin version issues, multi entry point output not working correctly without html plugin update, which breaks pwa plugin * make webpack pwa plugin work with html plugin >4 * incorporate: use full screen on mobile on menu pages and force title arrow to be next to title * remove console log * Restyled by prettier (#297) Co-authored-by: Restyled.io <[email protected]> * remove dev data leftovers Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a second entry point and bundle at
embed.htmlwith a reduced interface, but same capabilities.