fix: date offset and auto progress date #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Bundle difference
|
Bundle difference
|
Co-authored-by: Restyled.io <[email protected]>
Bundle difference
|
Merged
Bundle difference
|
Co-authored-by: Restyled.io <[email protected]>
Bundle difference
|
Co-authored-by: Restyled.io <[email protected]>
Bundle difference
|
2 similar comments
Bundle difference
|
Bundle difference
|
| @@ -129,6 +129,9 @@ export const CovMap = () => { | |||
| map.on("idle", handleMapIdleOrRemoved); | |||
| map.once("remove", handleMapIdleOrRemoved); | |||
| config.imageIcons?.map(({ id, url, pixelRatio, sdf }) => { | |||
| if (map.hasImage(id)) { | |||
There was a problem hiding this comment.
this has nothing to do with date offset and is just performance optimization?
DanielHabenicht
approved these changes
Oct 29, 2020
|
🎉 This PR is included in version 1.2.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally adds an hourly offset to the used date string, which allows the date string generated to load data to be in the past, not loading new data at 12pm exactly.
Note: also fixes an error when trying to add images to map which were already loaded.
@DanielHabenicht @ChristophWersal what nobody noticed so far... we never automatically increment the current date at any point. So unless you reload the app, you won't get new data. Simple approach would be to take
current date +- offset, calculate the duration to12pmand set a timeout to set the current date. This only works without the TimeSlider though, whenever you are looking at another day, it should not update the current date automatically. Currently everything is done in UTC, timezones are another topic. Friggin' dates...