Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix title check #267

Merged
merged 1 commit into from
Oct 28, 2020
Merged

chore: fix title check #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/pr-title-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: aslafy-z/conventional-pr-title-action@master
- uses: aslafy-z/conventional-pr-title-action@v2.2.3
id: title-check
with:
success-state: Title follows the specification.
Expand All @@ -32,8 +32,7 @@ jobs:
body-includes: Please make sure that your Pull Request title and body does conform to this format

- name: Create comment
# Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63
if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'true')
if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'false')
uses: peter-evans/create-or-update-comment@v1
with:
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -53,8 +52,7 @@ jobs:
In the Pull Request Body please describe what changes for the user of the application. If the user has to do Things different than before (excluding new functionality) please include `BREAKING CHANGE` at the end. This will trigger a major release (v1.0.0 -> v2.0.0)

- name: Delete comment
# Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63
if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'false')
if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'true')
uses: actions/github-script@v3
with:
script: |
Expand Down