Skip to content

Commit

Permalink
chore: fix title check (#267)
Browse files Browse the repository at this point in the history
Issue aslafy-z/conventional-pr-title-action#63 was resolved 

add version tag so it does not automatically update
  • Loading branch information
DanielHabenicht authored Oct 28, 2020
1 parent 6137bf3 commit 1558480
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/pr-title-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: aslafy-z/conventional-pr-title-action@master
- uses: aslafy-z/conventional-pr-title-action@v2.2.3
id: title-check
with:
success-state: Title follows the specification.
Expand All @@ -32,8 +32,7 @@ jobs:
body-includes: Please make sure that your Pull Request title and body does conform to this format

- name: Create comment
# Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63
if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'true')
if: always() && (steps.fc.outputs.comment-id == 0) && (steps.title-check.outputs.success == 'false')
uses: peter-evans/create-or-update-comment@v1
with:
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -53,8 +52,7 @@ jobs:
In the Pull Request Body please describe what changes for the user of the application. If the user has to do Things different than before (excluding new functionality) please include `BREAKING CHANGE` at the end. This will trigger a major release (v1.0.0 -> v2.0.0)
- name: Delete comment
# Attention title-check output is reversed: https://github.com/aslafy-z/conventional-pr-title-action/issues/63
if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'false')
if: always() && (steps.fc.outputs.comment-id != 0) && (steps.title-check.outputs.success == 'true')
uses: actions/github-script@v3
with:
script: |
Expand Down

0 comments on commit 1558480

Please sign in to comment.