-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infrastructure/update-storybook-config #20
infrastructure/update-storybook-config #20
Conversation
…. Also replace old container decorator with a margin decorator
Another update I just realized I didn't mention is that I moved all the filter components and associated files inside of the I'm not sure if there was an intentional reason that the filter components lived outside the |
@hawkticehurst Could you add commits from a recent PR (#19 ) to your PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As @tohuynh mentioned, just merge main
in to this branch prior to merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the essentials addons and the introduction doc, they are great. Just have a few requests for changes.
Since we are going to create an exportable App, changing the structure is fine as there will be other folders like state and containers later on.
Is it possible to make the background configurable in Docs mode as well? Right now, while in Docs mode, selecting light or grey doesn't change the background?
Could you add a prettierignore file to ignore SVG files? Right now running npm run format is returning an error since there's no parser for SVG files. https://prettier.io/docs/en/ignore.html
Also from what I could find in the storybook docs, there is no default way to dynamically change the doc theme from dark to light. However, there seems to be an addon that will let users toggle between dark mode and light mode. From my brief skim I'm not sure if this will also apply to docs as well (the app UI and docs are independent of each other in terms of theming), but I would be happy to take some time to experiment and add those changes to this PR if you'd prefer. |
If it's not possible using what we currently have, then it's no big deal. |
Pull Request Checklist
Summary Of Changes
PR includes various Storybook configuration updates, a new onboarding README, and version bumps to all Storybook packages.
Storybook Config Updates
A Note
The version bump to all Storybook packages seems to have changed (read: broken) some default styling of the current components. This issue has not been addressed due to the fact that issue #11 (adopting Mozilla styling protocol) will be resolved in the very near future and effectively make this problem moot.Update: The "broken styling" was because I removed an import for Semantic UI CSS styles in
preview.js
. With the import returned all is well in the land of CSS again.