Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-supervisor-role-title #180

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

evamaxfield
Copy link
Member

Link to Relevant Issue

This pull request resolves https://github.com/CouncilDataProject/king-county/runs/5874063516?check_suite_focus=true

Description of Changes

Include a description of the proposed changes.

New Role found by King County scraper: "Supervisor"
This seems like an official enough role and doesn't overlap with any of the current roles so makes sense to add and allow it through the pipeline.

@evamaxfield evamaxfield added the enhancement New feature or request label Apr 7, 2022
@evamaxfield evamaxfield self-assigned this Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #180 (dea4ad6) into main (2e472b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          50       50           
  Lines        2610     2611    +1     
=======================================
+ Hits         2471     2472    +1     
  Misses        139      139           
Impacted Files Coverage Δ
cdp_backend/database/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e472b9...dea4ad6. Read the comment docs.

@evamaxfield evamaxfield merged commit 510b57d into main Apr 7, 2022
@evamaxfield evamaxfield deleted the feature/add-supervisor-role-title branch April 7, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant