Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/fix-build #178

Merged
merged 3 commits into from
Apr 4, 2022
Merged

admin/fix-build #178

merged 3 commits into from
Apr 4, 2022

Conversation

evamaxfield
Copy link
Member

Fixes the current build on the repository. Main issues were outdated formatter and seattlechannel still has some cert issue which we have a reminder for in Slack, regardless of if that issue is fixed or not, we should be using local resources where possible to avoid issues like this in the future.

@evamaxfield evamaxfield added the bug Something isn't working label Apr 4, 2022
@evamaxfield evamaxfield self-assigned this Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #178 (1948c26) into main (f056a4a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   94.62%   94.67%   +0.04%     
==========================================
  Files          50       50              
  Lines        2605     2610       +5     
==========================================
+ Hits         2465     2471       +6     
+ Misses        140      139       -1     
Impacted Files Coverage Δ
...ckend/tests/pipeline/test_event_gather_pipeline.py 100.00% <100.00%> (ø)
cdp_backend/utils/file_utils.py 93.28% <100.00%> (-0.68%) ⬇️
cdp_backend/pipeline/event_gather_pipeline.py 86.29% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9be14...1948c26. Read the comment docs.

@evamaxfield evamaxfield merged commit 2e472b9 into main Apr 4, 2022
@evamaxfield evamaxfield deleted the admin/fix-build branch April 4, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant