Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/downloading-youtube-videos #169
feature/downloading-youtube-videos #169
Changes from 16 commits
2964a60
8c19331
e8c9012
e949add
c7e2085
86fb7d1
e1c6c84
fb618a7
b3d342e
4ad330b
f68c95e
5ae71f9
133d84e
96178d5
7e9aa14
48c6181
91fc71f
d007270
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was about to merge but one last look I think catches this.
This will always overwrite the supplied
dst
correct?I think there simply needs to be an
if dst is not None
before this statement.Additionally the docstring / parameter typing should be updated to
dst: Optional[Path] = None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I assumed that
dst
is not empty since ifdst
isNone
, it would be a assigned a value, as seen here. I can throw an exception ifdst
isNone
though. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh i see what you are doing. Yes. My mistake. Okay so then only nitpick would be instead of doing this
str(dst) + ".mp4"
string addition.Path
has a function calledwith_suffix
that is "safer" imo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes, you are correct. My mistake on on the overwrite vs simply adding the mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a new change based on your feedback.