Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/catch-timeout-in-event-gather #157

Merged

Conversation

isaacna
Copy link
Collaborator

@isaacna isaacna commented Jan 27, 2022

Link to Relevant Issue

This pull request resolves #154

Description of Changes

The error here was caused by a requests.ConnectionError.

I added a catch for ConnectionError for every try statement that uploads a db model and has resource_exists validation.

I'm assuming that wherever we don't have a try statement, we wouldn't want to proceed in the pipeline if something errors out during that upload_db_model step. But let me know if this assumption isn't correct

@isaacna isaacna requested a review from evamaxfield January 27, 2022 03:41
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #157 (ee791de) into main (4f8b6c7) will increase coverage by 0.00%.
The diff coverage is 45.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          50       50           
  Lines        2543     2544    +1     
=======================================
+ Hits         2404     2405    +1     
  Misses        139      139           
Impacted Files Coverage Δ
cdp_backend/pipeline/event_gather_pipeline.py 85.71% <45.45%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8b6c7...ee791de. Read the comment docs.

Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making these changes so quickly!

@evamaxfield evamaxfield merged commit 0a43a37 into CouncilDataProject:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch timeout / request rejections during event archiving
2 participants