Add option for WLabel, WText and WDynamicLabel to have shadows #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusElg
changed the title
Now it does 😉 |
|
The PR doesn't compile. Could you fix the compilation errors? The other PR's build is also failing. |
|
@Juuxel could you take a look at this? I would like to use it in my mod 😉 |
Juuxel
approved these changes
Aug 8, 2024
src/main/java/io/github/cottonmc/cotton/gui/widget/WDynamicLabel.java
Outdated
Show resolved
Hide resolved
MarcusElg
force-pushed
the
shadows-labels
branch
from
bdf2175
to
cb2d80e
Compare
|
Fixed |
|
@Juuxel sorry for pinging again, but could this be merged now that it's approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
Closes #233