Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationSet and related classes should respect organism's gene names #142

Open
fabio-t opened this issue Jan 24, 2020 · 0 comments
Open
Assignees
Labels

Comments

@fabio-t
Copy link
Member

fabio-t commented Jan 24, 2020

Related to #117, but more general and thus deserving of its own issue.

AnnotationSet fix_gene_names by default converts gene names to upper case. This is unnecessary when proper organism resolution is needed.

However, we do use jaspar_vertebrates, where a bunch of different organism-specific transcription factors are put together. So this requires a bigger discussion, and quite possibly we should leave to the user the decision of whether to "upper" all genes or keep the original name.

@fabio-t fabio-t self-assigned this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant