Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add wasm module v1-beta #71

Merged
merged 5 commits into from
Oct 25, 2021
Merged

feat: Add wasm module v1-beta #71

merged 5 commits into from
Oct 25, 2021

Conversation

giansalex
Copy link
Member

@giansalex giansalex commented Oct 22, 2021 •
edited
Loading

This includes:

  • wasmd v1-beta fork
  • Preserves cosmoscmd (and wasm cli options added) to avoid redundant code

image
image

  • Update dockerfile

close #70
close #24

@giansalex giansalex changed the title Add wasm v1-beta feat: Add wasm module v1-beta Oct 22, 2021
@the-frey
Copy link
Contributor

Yeah this is much terser than mine - we should review and test this one instead @faddat & @dimiandre

@the-frey the-frey requested review from faddat and dimiandre October 22, 2021 09:08
@faddat
Copy link
Contributor

faddat commented Oct 22, 2021

ok, I'm doin my thing.

thanks @giansalex

@the-frey the-frey self-requested a review October 24, 2021 11:47
@the-frey
Copy link
Contributor

@giansalex as I mentioned on the other thread LGTM from my perspective - just need to resolve deps as they've moved on main :)

@giansalex
Copy link
Member Author

@the-frey updated.

@JakeHartnell JakeHartnell self-requested a review October 25, 2021 04:55
@JakeHartnell
Copy link
Contributor

Nice and clean, let's give this a test with Uni. If anyone tags this, please indicate that it's a beta. Would be nice to reserve 2.0.0 for the actual mainnet release.

the-frey
the-frey approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@the-frey the-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @faddat or @dimiandre have you had a chance to test and are you happy to move forward with this?

faddat
faddat approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and test contracts for consistency

@faddat
Copy link
Contributor

faddat commented Oct 25, 2021

Versioning preference:

releases get tagged
pre-releases get tagged as pre-releases (this is the go convention)

thus:

we'd tag this v2.0.0-alpha

then

v2.0.0-beta

then

v2.0.0

@JakeHartnell JakeHartnell merged commit 631f8f7 into CosmosContracts:main Oct 25, 2021
@giansalex giansalex deleted the wasmd-v1-beta branch November 1, 2021 04:13
@the-frey the-frey mentioned this pull request Nov 22, 2021
Closed
6 tasks
@RafilxTenfen RafilxTenfen mentioned this pull request Apr 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@the-frey the-frey the-frey approved these changes

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@dimiandre dimiandre Awaiting requested review from dimiandre dimiandre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to CosmWasm v1
4 participants
@giansalex @the-frey @faddat @JakeHartnell