Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/globalfee #411

Merged
merged 2 commits into from
Dec 13, 2022
Merged

x/globalfee #411

merged 2 commits into from
Dec 13, 2022

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Dec 12, 2022

Pulled forward from Gaiav8 - SDK v45 for Juno v12

Commonwealth: https://commonwealth.im/juno/discussion/8386-implement-xglobalfee
Chain prop: https://www.mintscan.io/juno/proposals/68

Feature:

- Sets a minimum fee for the entire network
- A Node can set a higher fee than the minimum, but not lower
- Validators can not accept anything which is not in the globalfee params

After upgrade, community can decide on good fees / denoms to accept (usdc, juno, osmo)

junod tx gov submit-proposal param-change ~/Desktop/Work/paramChange.json --from $KEY --keyring-backend os --chain-id juno-1 --yes --broadcast-mode block

{
    "title": "MinimumGasPricesParam Change",
    "description": "add juno minimum fee",
    "changes": [
      {
        "subspace": "globalfee",
        "key": "MinimumGasPricesParam",
        "value": [{"denom":"ujuno","amount":"0.002500000000000000"}]
      }
    ],
    "deposit": "1000000ujuno"
}

@Reecepbcups Reecepbcups changed the title Fresh x/globalfee x/globalfee Dec 12, 2022
@Reecepbcups Reecepbcups marked this pull request as ready for review December 12, 2022 21:08
@Reecepbcups
Copy link
Contributor Author

@faddat built off main, and used the same as before. Works just fine... If you could update the commonwealth to this PR now. I closed the other. Ready for review

@Reecepbcups Reecepbcups enabled auto-merge (squash) December 12, 2022 21:13
@Reecepbcups Reecepbcups added the review me Review me for merge label Dec 13, 2022
Copy link
Collaborator

@the-frey the-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Weird about that other thing.

@Reecepbcups Reecepbcups merged commit f3383da into main Dec 13, 2022
@faddat
Copy link
Contributor

faddat commented Dec 13, 2022

@Reecepbcups - stuff's odd sometimes (re: rebuilding off of main) I'll put this on CW.

app/app.go Show resolved Hide resolved
@Reecepbcups Reecepbcups removed the review me Review me for merge label Dec 14, 2022
@Reecepbcups Reecepbcups deleted the reece/globalfee-2nd-try branch March 28, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants