-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement x/feeshare #385
implement x/feeshare #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still have some minor issue and not have proposal for change DeveloperShares yet. Can you check this?
@GNaD13 It is the the params, so |
I am now feeling lgtmification here. |
Co-authored-by: Jake Hartnell <[email protected]>
Co-authored-by: Jake Hartnell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Can't wait to play with this in the next testnet!
LGTM. I think we'll end up with some nits once we move this into test, but we probably won't catch them all until we get it on uni and start kicking the tyres. |
Closes #386
This is the module to fulfill the % of fees going to dAPP developers.
Features:
tested with:
Future Needs: