Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement x/feeshare #385

Merged
merged 37 commits into from
Dec 12, 2022
Merged

implement x/feeshare #385

merged 37 commits into from
Dec 12, 2022

Conversation

Reecepbcups
Copy link
Contributor

@Reecepbcups Reecepbcups commented Nov 30, 2022

Closes #386
This is the module to fulfill the % of fees going to dAPP developers.

Features:

  • You can specify a separate withdraw address
  • Only contracts you are an admin of can you register payouts for (opt in requirement for tax reasons)
  • 50% of funds by default, governance can enable / change the % to any amount they like
  • Splits fees across multiple ExecuteMsg's in 1 transaction if there are
  • Developer revenue % can be between 1% and 100%. Gov toggle on/off

tested with:

Future Needs:

  • e2e

@Reecepbcups Reecepbcups marked this pull request as ready for review December 5, 2022 04:05
@Reecepbcups Reecepbcups mentioned this pull request Dec 5, 2022
9 tasks
scripts/protocgen.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@GNaD13 GNaD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still have some minor issue and not have proposal for change DeveloperShares yet. Can you check this?

x/feeshare/keeper/msg_server.go Outdated Show resolved Hide resolved
x/feeshare/keeper/msg_server.go Outdated Show resolved Hide resolved
x/feeshare/keeper/msg_server.go Outdated Show resolved Hide resolved
x/feeshare/keeper/msg_server.go Outdated Show resolved Hide resolved
x/feeshare/client/cli/query.go Show resolved Hide resolved
x/feeshare/client/cli/tx.go Show resolved Hide resolved
x/feeshare/client/cli/tx.go Outdated Show resolved Hide resolved
x/feeshare/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/feeshare/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/feeshare/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/feeshare/ante/ante.go Outdated Show resolved Hide resolved
@Reecepbcups
Copy link
Contributor Author

I think we still have some minor issue and not have proposal for change DeveloperShares yet. Can you check this?

@GNaD13 It is the the params, so junod tx gov submit-proposal param-change would do

@faddat
Copy link
Contributor

faddat commented Dec 7, 2022

I am now feeling lgtmification here.

@faddat faddat enabled auto-merge December 7, 2022 12:27
Makefile Show resolved Hide resolved
faddat
faddat previously approved these changes Dec 7, 2022
app/modules.go Outdated Show resolved Hide resolved
Co-authored-by: Jake Hartnell <[email protected]>
x/feeshare/README.md Outdated Show resolved Hide resolved
Co-authored-by: Jake Hartnell <[email protected]>
Copy link
Contributor

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Can't wait to play with this in the next testnet!

@the-frey
Copy link
Collaborator

the-frey commented Dec 9, 2022

LGTM. I think we'll end up with some nits once we move this into test, but we probably won't catch them all until we get it on uni and start kicking the tyres.

@faddat faddat merged commit 36e2fd2 into main Dec 12, 2022
@vuong177 vuong177 mentioned this pull request Dec 13, 2022
6 tasks
@Reecepbcups Reecepbcups mentioned this pull request Feb 6, 2023
9 tasks
@Reecepbcups Reecepbcups deleted the feeshare branch March 28, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl of FeeShare Module
5 participants