Unpin Hypothesis version and delete dupilcated .github directory #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 19 19
Lines 808 808
=======================================
Hits 797 797
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
Ooops sorry. I used the GitHub UI to create the new file and I didn't see the trailing whitespace. My bad! |
pllim
reviewed
Mar 22, 2024
| @@ -45,7 +45,7 @@ mkdocstrings = "^0.23.0" | |||
| mkdocstrings-python = "^1.7.3" | |||
| ruff = "^0.1.4" | |||
| markdown = "<3.4.0" | |||
| hypothesis = "<=6.47.5" | |||
| hypothesis = "6.99.11" | |||
There was a problem hiding this comment.
I don't use poetry but I noticed that this has no operator in front like the others. Was this intentional?
There was a problem hiding this comment.
Good catch ! My bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12. The reason that tests failed after the update seems to have been that a newer hypothesis version set an upper limit to
min_valuein thelistsstrategy.I also saw that the .github directory got duplicated following #11. dependabot.yml is now moved to the older .github directory.