Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placeholder placement when using left view in textfield #544

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fix placeholder placement when using left view in textfield #544

merged 1 commit into from
Oct 12, 2016

Conversation

Ekko-System
Copy link

No description provided.

@Ekko-System
Copy link
Author

First pull request for me, if there is anything to change tell me

@daniel-jonathan
Copy link
Member

Wonderful, thank you. Can you send this update to development, and then I can review and merge :)

@daniel-jonathan daniel-jonathan self-assigned this Oct 8, 2016
@Ekko-System Ekko-System changed the base branch from master to development October 9, 2016 10:14
@daniel-jonathan
Copy link
Member

daniel-jonathan commented Oct 11, 2016 •
edited
Loading

I will be reviewing this tomorrow for a merge :) If all is well, this will be a part of tomorrow's release. Thank you!

daniel-jonathan
daniel-jonathan approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, there are some style modifications to make, but I will do that. I am merging this in :) Thank you!

@daniel-jonathan daniel-jonathan merged commit 027880b into CosmicMind:development Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-jonathan daniel-jonathan daniel-jonathan approved these changes

Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ekko-System @daniel-jonathan