Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extensions #1147

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Support extensions #1147

merged 2 commits into from
Sep 10, 2018

Conversation

ConfusedVorlon
Copy link
Contributor

Use an extension safe Application.shared

Use an extension safe Application.shared
Copy link
Contributor

@OrkhanAlikhanov OrkhanAlikhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@@ -31,9 +31,20 @@
import UIKit

public struct Application {

public static var shared: UIApplication {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline documentation would be desirable

@ConfusedVorlon
Copy link
Contributor Author

Documentation added

@daniel-jonathan
Copy link
Member

@ConfusedVorlon awesome! Thank you. Also, please send PRs to development in the future :)

@daniel-jonathan daniel-jonathan merged commit d82a9cd into CosmicMind:development Sep 10, 2018
@ConfusedVorlon ConfusedVorlon deleted the support_extensions_squash branch September 13, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants