Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextField placeholderLabel position #1093

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Fix TextField placeholderLabel position #1093

merged 1 commit into from
Jun 7, 2018

Conversation

jbaez
Copy link
Contributor

@jbaez jbaez commented Jun 7, 2018

This fix reverts to the old way of positioning the placeholder label by using frame instead of bounds #1092

OrkhanAlikhanov
OrkhanAlikhanov approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@OrkhanAlikhanov OrkhanAlikhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

daniel-jonathan
daniel-jonathan approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daniel-jonathan daniel-jonathan merged commit 6703a40 into CosmicMind:development Jun 7, 2018
@daniel-jonathan daniel-jonathan self-assigned this Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrkhanAlikhanov OrkhanAlikhanov OrkhanAlikhanov approved these changes

@daniel-jonathan daniel-jonathan daniel-jonathan approved these changes

Assignees

@daniel-jonathan daniel-jonathan

Labels
fix material
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbaez @daniel-jonathan @OrkhanAlikhanov