Expose libwasmvm version number at runtime #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
webmaster128
force-pushed
the
expose_version_number
branch
from
b2f5430
to
6a45a00
Compare
webmaster128
force-pushed
the
expose_version_number
branch
from
6a45a00
to
0c9a20a
Compare
maurolacy
approved these changes
May 3, 2022
api/version_test.go
Outdated
| func TestLibwasmvmVersion(t *testing.T) { | ||
| version, err := LibwasmvmVersion() | ||
| require.NoError(t, err) | ||
| require.Equal(t, "1.0.0", version) |
There was a problem hiding this comment.
Will this have to be updated with every version change? Better to use a VERSION tag or ref from somewhere. Perhaps some dirty code to parse the Cargo.toml from Go? That, or do some structural checks here only.
There was a problem hiding this comment.
Right, this is a leftover from development state. Ideally we use a simple regex here to ensure we get something sane.
| use std::ffi::CStr; | ||
|
|
||
| #[test] | ||
| fn version_works() { |
ethanfrey
approved these changes
May 3, 2022
| /// | ||
| /// The string is owned by libwasmvm and must not be mutated or destroyed by the caller. | ||
| #[no_mangle] | ||
| pub extern "C" fn version_str() -> *const c_char { |
webmaster128
force-pushed
the
expose_version_number
branch
from
0c9a20a
to
326e010
Compare
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's tricky for validators to get the correct .so file used with their binary. This happens when the binary is built on one system and is then deployed to multiple nodes. Go installs the .so to a very custom path in the Go installation system.
Now what we want to do is provide information of the Rust side (libwasmvm) at runtime. This way you can veryify that your wasmvm 1.2.3 dependency loaded the 1.2.3 shared library and not something old that was installed from last time such as 1.2.1.
Ideally we find a way to get this listed in the chain's long version output, e.g. in here
With this PR the release process needs a bit more steps since the libwasmvm project version needs to be updated before the release tag is set.