Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmwasm 0.16 #247

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Cosmwasm 0.16 #247

merged 6 commits into from
Jul 20, 2021

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 19, 2021

Closes #246
Closes #239

types/ibc.go Outdated Show resolved Hide resolved
types/ibc.go Show resolved Hide resolved
@uint uint requested review from webmaster128 and ethanfrey July 19, 2021 17:30
@webmaster128
Copy link
Member

Could you close #239 in this PR too? IIRC we added test events in one of the development contracts that we can inspect in Go tests.

@webmaster128
Copy link
Member

webmaster128 commented Jul 20, 2021

Looks good. We just need tests to check we get those events in Go:

    Ok(IbcBasicResponse {
        messages: vec![msg],
        attributes: vec![attr("action", "ibc_connect"), attr("channel_id", chan_id)],
        events: vec![Event::new("ibc").attr("channel", "connect")],
    })

and

    .or_else(|e| {
        // we try to capture all app-level errors and convert them into
        // acknowledgement packets that contain an error code.
        let acknowledgement = encode_ibc_error(format!("invalid packet: {}", e));
        Ok(IbcReceiveResponse {
            acknowledgement,
            messages: vec![],
            attributes: vec![],
            events: vec![Event::new("ibc").attr("packet", "receive")],
        })
    })

from contracts/ibc-reflect/src/contract.rs

@uint
Copy link
Contributor Author

uint commented Jul 20, 2021

Looks good. We just need tests to check we get those events in Go:

I was already working on that :D

@uint
Copy link
Contributor Author

uint commented Jul 20, 2021

I think we're good!

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let's release that as wasmvm 0.16.0-rc1 for integration in wasmd

@webmaster128 webmaster128 merged commit d767103 into main Jul 20, 2021
@webmaster128 webmaster128 deleted the cosmwasm-0.16 branch July 20, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to cosmwasm 0.16 Add custom events to IBC response(s)
2 participants