-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmwasm 0.15 #225
Cosmwasm 0.15 #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with this the audit job passes already.
Rebased to get rid of the |
@webmaster128 I'm struggling with how to represent I feel like this should be some sort of integer code, and maybe iota would make this easier. But then, we would probably want to hardcode the integer values on Rust side too, wouldn't we? What do you think? EDIT: Nvm, I think I figured it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good
I think the single source of truth is the JSON Schema:
This is what is passed over FFI. Rust does not need to care how Go picks this up. If the int solution of a string solution is better for Go callers, I don't know. I think is is good to fail for non allowed values. |
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
Closes #224